search

Shopify / mobile-buy-sdk-ios

Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.
MIT License
452 stars 199 forks source link

Add note-attribute to BUYCheckout #92

Closed mpushki closed 8 years ago

mpushki commented 8 years ago

Is it possible?

runmad commented 8 years ago

Yes: https://github.com/Shopify/mobile-buy-sdk-ios/blob/master/Mobile%20Buy%20SDK/Mobile%20Buy%20SDK/Models/BUYCheckout.h#L244

mpushki commented 8 years ago

This is for note, and i mean note_attribute

mpushki commented 8 years ago

Note_attribute is array with non-default settings

runmad commented 8 years ago

Ah, sorry I misunderstood!

Right now, unfortunately it's not possible, but I'll re-open the ticket to keep track.

mpushki commented 8 years ago

Thank you. Could you tell me how long does it take? It is an urgent task for me - if it is a long time for you then I'll look for other ways to solve for me

runmad commented 8 years ago

@mariapush I have a PR up, it's possible to do it with it, but I would recommend you wait until it's in a release.

Unfortunately I cannot say when this will be.

mpushki commented 8 years ago

@runmad Thanks, but one more question - Please could you add this attribute for Android mobile SDK too?

runmad commented 8 years ago

It's been merged into develop, look out for this in our next release.

And yes, we will be adding this on the Android Mobile Buy SDK as well. cc @krisorr

krisorr commented 8 years ago

This update has been added to the Android develop branch. https://github.com/Shopify/mobile-buy-sdk-android/issues/22

mpushki commented 7 years ago

Hi all, I have problem with SDK version 2: https://ecommerce.shopify.com/c/shopify-apis-and-technology/t/checkout-attribute-in-new-sdk-422999 Say to create threads on the forum but I practically do not get any answers there