search

Shopify / mobile-buy-sdk-ios

Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.
MIT License
452 stars 199 forks source link

CheckoutViewModel lineItemDiscountName concatenated 5 times #961

Closed natecraft1 closed 5 years ago

natecraft1 commented 5 years ago

@dbart01 When I submit a discount, for example "helloworld", the CheckoutViewModel comes back with it's lineItemDiscountName property as "helloworld, helloworld, helloworld, helloworld, helloworld"

dbart01 commented 5 years ago

Is this something that happens in the vanilla sample app?

natecraft1 commented 5 years ago

I don't know if it happens in the sample app, but it's happening in our app.

dbart01 commented 5 years ago

The reason I ask is because CheckoutViewModel (in fact, the entire view model architecture) is not directly under the SDK domain. It's provided as an example of how one might implement the SDK in their custom storefront. Having said that, I don't know what your app looks like or what has happened to the architecture if you ended up using the sample app as a template. If this is not something that happens in the sample app, I have reason to believe that it's an issue with the implementation in your application, rather than the SDK.