Fix queries sample code in README

Shopify / mobile-buy-sdk-ios

Shopify’s Mobile Buy SDK makes it simple to sell physical products inside your mobile app. With a few lines of code, you can connect your app with the Shopify platform and let your users buy your products using Apple Pay or their credit card.

MIT License

452 stars 199 forks source link

Fix queries sample code in README #982

Closed chriscomeau closed 5 years ago

chriscomeau commented 5 years ago

What this does

Fix queries sample code in README that didn't seem to compile in my test app (to learn the Buy SDK), using Xcode 10.2 and Swift 5.0.

Compilation error message I had: Contextual type for closure argument list expects 1 argument, which cannot be implicitly ignored

Added a missing $0 to a call to Storefront.buildQuery in the Queries sections of the README tutorial.

dbart01 commented 5 years ago

Thanks for the contribution! Could you please rebase on develop instead of master?

chriscomeau commented 5 years ago

Oops, thanks @dbart01 for the feedback, i'll make sure to stick to "develop" from now on! I'm closing this PR and opening a new PR https://github.com/Shopify/mobile-buy-sdk-ios/pull/983.