search

Shopify / mruby-engine

MRuby engine is a sandboxed scripting engine.
MIT License
80 stars 18 forks source link

Clone submodules #36

Closed craiglrock closed 7 years ago

craiglrock commented 7 years ago

we need the submodules when deploying to package cloud

alexsnaps commented 7 years ago

I fear this may be an issue if it reuses cached images (I had to nuke that cache a couple of times in the past)… but I do not know really :/

alexsnaps commented 7 years ago

Dunno (still!) but I wonder if git submodule update --init isn't safer. i.e. init if needs be, but update if required. i.e. if it is there, but is an older version (i.e. as when we update mruby), then I think this should behave as intended. And I think submodules could already be checked out (i.e. init'ed) if the image used to build is reused... again, I do not know really, but… a hunch :P

alexsnaps commented 7 years ago

It's been git submodule update all along, and not git submodule init… You're drunk Alex, go home!