Shopify / omniauth-shopify-oauth2

Shopify OAuth2 Strategy for OmniAuth 1.0
http://shopify.github.io/omniauth-shopify-oauth2
91 stars 69 forks source link

Provide a configurable myshopify domain. #13

Closed garymardell closed 10 years ago

garymardell commented 10 years ago

@peterjm @christhomson @EiNSTeiN-

myshopify domain now becomes an option when setting up the omniauth builder. Defaults to myshopify.com.

I have also changed the valid_site? method to actually return a boolean in both cases and added a spec.

Rails.application.config.middleware.use OmniAuth::Builder do
  provider :shopify, ENV['SHOPIFY_API_KEY'], ENV['SHOPIFY_SHARED_SECRET'],
    myshopify_domain: 'myshopify.io'
end

I could rename the option, but it shouldn't be changed often.

christhomson commented 10 years ago

:mountain_cableway: :dash:

peterjm commented 10 years ago

:+1:

EiNSTeiN- commented 10 years ago

:+1:

maartenvg commented 10 years ago

Yes please! :+1: