Closed tylerball closed 5 years ago
@EiNSTeiN- sure I can release this as a breaking change.
I agree with Francois, why do we need the fallback as part of this?
@EiNSTeiN- @ragalie updated this to stop using the param and will be released as 2.0.0
Last year we switched
shopify_app
over to storing the shop name in the session instead of sending it as a param to omniauth. However thesetup
key in the example app was not updated, nor was the README, leading toinvalid_site
errors for developers (including me). Most of our internal apps override this method to grab the shop out of the session, despite this not really being documented anywhere.Ideally developers shouldn't have to set this key at all and this library should just work. This PR makes the auth route pull the shop from session, falling back to the param as it did before.