Shopify / omniauth-shopify-oauth2

Shopify OAuth2 Strategy for OmniAuth 1.0
http://shopify.github.io/omniauth-shopify-oauth2
91 stars 69 forks source link

Add user session information to auth_hash #83

Closed theundeadmonk closed 5 years ago

theundeadmonk commented 5 years ago

The Shopify Omniauth2 gem selectively wraps the parameters it receives into a custom Hash object. It discards all parameters that are not specified as part of the strategy.

Since we now pass a user session along with per-user tokens, we need to ensure that the auth hash object constructed by the gem has the session information.

This PR adds the session to the auth hash.

theundeadmonk commented 5 years ago
Screen Shot 2019-10-10 at 1 52 11 PM
theundeadmonk commented 5 years ago
Screen Shot 2019-10-10 at 1 52 11 PM
ashchristopher commented 5 years ago

🎉

wnm commented 3 years ago

Hi @theundeadmonk, do you know if the session in the auth hash is supposed to be the same, as the session which is passed as a parameter when opening an app from a store's app dashboard (mystore.com/admin/apps)?

There is an issue in the shopify_app gem related to this: Shopify/shopify_app#1181

theundeadmonk commented 3 years ago

Yes