search

Shopify / oxidized

configuration backup software (IOS, JunOS) - silly attempt at rancid
4 stars 4 forks source link

Testing refactoring #2

Closed ElvinEfendi closed 8 years ago

ElvinEfendi commented 8 years ago

I've fixed problems with test environment setup and configured the gem to use minitest for testing. Then added specifications that covers core flow such as fetching the config and storing it. Moreover I did some code refactoring on the way.

@Shopify/traffic

ElvinEfendi commented 8 years ago

@ibawt and @charlescng can you review this?

ibawt commented 8 years ago

LGTM. Nice job on the code quality.

charlescng commented 8 years ago

LGTM. Can we setup Travis CI as well?

ElvinEfendi commented 8 years ago

@charlescng test specs assumes that there is ~/.config/oxidized/routers.db file with list of at least 3 online network devices that are accessible via ssh from the host machine. I do not know how to handle this in Travis. Any suggestion?

ElvinEfendi commented 8 years ago

I tried to make the code base more test friendly and integrated Travic CI. @ibawt @charlescng @marc-barry

ibawt commented 8 years ago

cool I think it's time to merge