Shopify / oxidized

configuration backup software (IOS, JunOS) - silly attempt at rancid
4 stars 4 forks source link

CSV key assignment should be consistent #22

Open ElvinEfendi opened 8 years ago

ElvinEfendi commented 8 years ago

https://github.com/Shopify/oxidized/blob/master/lib/oxidized/source/csv.rb#L28 (keys[key.to_sym] = data[position]) should follow the same convention(assigning nil when value is empty) as https://github.com/Shopify/oxidized/blob/master/lib/oxidized/source/csv.rb#L34 (vars[key.to_sym] = data[position].to_s.empty? ? nil : data[position])