Closed alexevanczuk closed 1 year ago
@gmcgibbon We could add v*
as one of the branches that always gets CI, so maintenance versions can have ci with a branch name like v2.x
, for example.
Happy to close this if you think the less redundant output is not worth the additional complexity.
Let's add *-stable
to the list because that's the naming scheme we use. https://github.com/Shopify/packwerk/tree/2-stable. I don't object to trying this, so I'll approve once that's added.
Okay done @gannon!
Previously, I merged https://github.com/Shopify/packwerk/pull/236 (has screenshots), since we see duplicate checks run on every build.
This had to be reverted here https://github.com/Shopify/packwerk/pull/240 because it ended up not running checks on push from a fork from an external contributor.
Searching github community, I found a suggested solution: https://github.com/orgs/community/discussions/26940#discussioncomment-5686753
We'll want to test this solution and revert if it doesn't work in the following contexts: