Requalify strict violations

[alxckn]

What are you trying to accomplish?

This is a proposal to change how strict_mode_violations offenses are gathered and prevent the update_todo from updating a package_todo.yml file with new violations once the strict mode is activated for a package.

Currently the OffenseCollection class will only check whether an offense qualifies as a strict mode violation if it was already present in the file package_todo.yml, I think it should be up to the checker to determine whether offenses, known or unknown, qualify as strict mode violations.

Down the line, the goal would be to enable checkers to apply a 'less strict' mode where new violations cannot be added to the package_todo.yml file but violations that were written to the file before do not cause an error. This would be for packages where it is difficult to reach an empty package_todo.yml but we want to stop the bleeding.

What approach did you choose and why?

• Always ask the checker whether an offense is a strict mode violation and add it to the list if it is
• Update of package_todo.yml does not include new strict mode violations. Being able to update the list with strict mode violations may lead to errors where new violations are not considered new after the file is updated

What should reviewers focus on?

• Current usage of the gem and whether it would harm some existing workflows (I am not sure it would as a zero strict mode violations policy is currently enforced by all checkers)

Type of Change

• [ ] Bugfix
• [x] New feature
• [ ] Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

• [x] Breaking change (fix or feature that would cause existing functionality to change)

Update with the update_todo command of package_todo.yml would fail in cases where it would work today

Checklist

• [x] I have updated the documentation accordingly.
• [x] I have added tests to cover my changes.
• [x] It is safe to rollback this change.

[alxckn]

It feels like possibly an alternative to https://github.com/Shopify/packwerk/pull/365, cc @athieriot

I think what this PR proposes and what's in @athieriot's PR could be complementary. At Doctolib we have some heterogeneous needs with packages where we'd like to use strict mode only for new violations (this PR + changes in the way strict mode violations are computed at the checker level) and other packages where we'd like to enforce strict mode for 'application' code but we can't enforce it in test setups.

[alexevanczuk]

This looks good to me. @rafaelfranca do you have any feedback or are we good to merge and release?

[rafaelfranca]

CLA needs to be signed before we merge this though.

[rafaelfranca]

Ah, it was.