Allow to configure parsers in packwerk (continued) - Githubissues

Shopify / packwerk

Good things come in small packages.

MIT License

1.59k stars 110 forks source link

Allow to configure parsers in packwerk (continued) #374

Closed richardmarbach closed 11 months ago

richardmarbach commented 11 months ago

What are you trying to accomplish?

Since no further development has taken place on #243, I hope it's ok that I've taken the liberty to implement the requested changes from https://github.com/Shopify/packwerk/pull/243#issuecomment-1339428760

What approach did you choose and why?

What should reviewers focus on?

This is the first time I've used minitest. Would love some feedback on if there's a better way to write the tests.

Type of Change

[ ] Bugfix
[x] New feature
[ ] Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Additional Release Notes

[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] It is safe to rollback this change.