Change recommended drawing library

euglena1215 commented 8 months ago

What are you trying to accomplish?

Change the drawing library introduced as the packwerk ecosystem from graphwerk gem to visualize_packs gem.

What approach did you choose and why?

The graphwerk gem is introduced as part of the ecosystem, but the graphwerk gem has not been maintained recently.

Since the visualize_packs gem is more actively maintained, I thought it would be appropriate to introduce the visualize_packs gem as part of the ecosystem.

What should reviewers focus on?

Please determine if the visualize_packs gem is appropriate as a recommended drawing library.

Type of Change

[ ] Bugfix
[ ] New feature
[x] Non-breaking change (a change that doesn't alter functionality - i.e., code refactor, configs, etc.)

Checklist

[x] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] It is safe to rollback this change.

euglena1215 commented 8 months ago

I have signed the CLA!

euglena1215 commented 8 months ago

@gmcgibbon Thanks for the review. I did not know that the visualize_packs gem depends on the directory name "packs". So I can understand why it is not accepetable.

alexevanczuk commented 8 months ago

Hey @euglena1215 just wanted to chime in to say that packs-rails and the packs spec in general defaults to ./packs as the root dir, but the pack directories are totally configurable. Only saying that to clear up any misconceptions!

Shopify / packwerk