Shopify / packwerk

Good things come in small packages.
MIT License
1.54k stars 111 forks source link

Centralize Ruby Version to `.ruby-version` #399

Closed jenshenny closed 1 month ago

jenshenny commented 3 months ago

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

[!IMPORTANT] Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

Please merge this PR if it looks good, or make any adjustments. This PR will be addressed if there isn't any activity after 4 weeks.

george-ma commented 2 months ago

I dropped Rails 6.0 support on CI tests to get CI passing as this version has had security support dropped for almost a year (~11 months)

Let me know if I should split up this removal commit and a1e3910 into their own PRs.

jenshenny commented 1 month ago

Closing in favour of: https://github.com/Shopify/packwerk/pull/407