Closed jenshenny closed 1 month ago
I dropped Rails 6.0 support on CI tests to get CI passing as this version has had security support dropped for almost a year (~11 months)
Let me know if I should split up this removal commit and a1e3910 into their own PRs.
Closing in favour of: https://github.com/Shopify/packwerk/pull/407
What are you trying to accomplish?
The
.ruby-version
file is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-version
file, ensures arequired_ruby_version
is set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-version
file is present with the correct Ruby version definedrequired_ruby_version
in your gemspec is setdev.yml
Ruby task (before:- ruby: x.x.x
, after:- ruby
)Gemfile
(no lines withruby <some-version>
)Gemfile.lock
is built with the defined Ruby versionTargetRubyVersion
defined inrubocop.yml
(reads fromrequired_ruby_version
on Rubocop 1.61.0)ruby/setup-ruby
Github Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”
)Please merge this PR if it looks good, or make any adjustments. This PR will be addressed if there isn't any activity after 4 weeks.