github-actions[bot]
commented
4 months ago size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| polaris-viz-core-cjs | 61.15 KB (+0.01% 🔺) | 1.3 s (+0.01% 🔺) | 1.1 s (+16.22% 🔺) | 2.4 s |
| polaris-viz-cjs | 215.97 KB (+0.01% 🔺) | 4.4 s (+0.01% 🔺) | 2 s (-11.96% 🔽) | 6.3 s |
| polaris-viz-esm | 176.7 KB (+0.01% 🔺) | 3.6 s (+0.01% 🔺) | 1.4 s (-1.08% 🔽) | 5 s |
| polaris-viz-css | 4.79 KB (0%) | 96 ms (0%) | 312 ms (-18.03% 🔽) | 408 ms |
| polaris-viz-esnext | 182.48 KB (+0.02% 🔺) | 3.7 s (+0.02% 🔺) | 1.7 s (-2.7% 🔽) | 5.3 s |
envex
What does this implement/fix?
The legend overflow calculation was using the
MINIMUM_LEGEND_ITEM_WITH_VALUE_WIDTHinstead ofMINIMUM_LEGEND_ITEM_WIDTHwhen values were hidden. But I also just learned that horizontal legends with values look like this, so we don't even needMINIMUM_LEGEND_ITEM_WITH_VALUE_WIDTH.Does this close any currently open issues?
Resolve https://github.com/Shopify/core-issues/issues/73670 One of feedback items we received from CSS here: https://github.com/Shopify/core-issues/issues/72480
What do the changes look like?
Legend items should shorten to
100pxbefore items start being hiddenhttps://github.com/user-attachments/assets/12c569a3-c3ea-422a-933f-6efb242cfce4
Storybook link
https://6062ad4a2d14cd0021539c1b-abxwzkkvsr.chromatic.com/
Before merging
[ ] Check your changes on a variety of browsers and devices.
[ ] Update the Changelog's Unreleased section with your changes.
[ ] Update relevant documentation, tests, and Storybook.
[ ] Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package