github-actions[bot]
commented
3 months ago size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| polaris-viz-core-cjs | 61.15 KB (0%) | 1.3 s (0%) | 927 ms (-26.85% 🔽) | 2.2 s |
| polaris-viz-cjs | 215.23 KB (+0.02% 🔺) | 4.4 s (+0.02% 🔺) | 2.5 s (+31.93% 🔺) | 6.9 s |
| polaris-viz-esm | 176.18 KB (+0.01% 🔺) | 3.6 s (+0.01% 🔺) | 1.8 s (+9.87% 🔺) | 5.3 s |
| polaris-viz-css | 4.73 KB (+0.05% 🔺) | 95 ms (+0.05% 🔺) | 338 ms (+51.3% 🔺) | 433 ms |
| polaris-viz-esnext | 181.83 KB (+0.01% 🔺) | 3.7 s (+0.01% 🔺) | 1.5 s (+10.9% 🔺) | 5.1 s |
What does this implement/fix?
The inner value content font size in the donut chart was set to a static value, which led to this value not being scaled with the donut size. Now, we calculate the font size based on the donut diameter.
Does this close any currently open issues?
Related https://github.com/Shopify/core-issues/issues/74510
What do the changes look like?
Storybook link
🎩 Small donut 🎩 Medium donut 🎩 Large donut
Before merging
[x] Check your changes on a variety of browsers and devices.
[x] Update the Changelog's Unreleased section with your changes.
[x] Update relevant documentation, tests, and Storybook.
[ ] Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package