Shopify / polaris-viz

A collection of React and React native components that compose Shopify's data visualization system
https://polaris-viz.shopify.dev
Other
335 stars 25 forks source link

[Donut chart] Show empty state when all values are zero #1717

Closed michaelnesen closed 2 months ago

michaelnesen commented 2 months ago

What does this implement/fix?

Does this close any currently open issues?

What do the changes look like?

Screenshot 2024-08-30 at 10 12 57 AM

Storybook link

https://6062ad4a2d14cd0021539c1b-rkoidmddvx.chromatic.com/

Before merging

github-actions[bot] commented 2 months ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.19 KB (0%) 1.3 s (0%) 1.1 s (+8.77% 🔺) 2.4 s
polaris-viz-cjs 215.35 KB (+0.02% 🔺) 4.4 s (+0.02% 🔺) 2.3 s (+56.7% 🔺) 6.6 s
polaris-viz-esm 176.24 KB (+0.02% 🔺) 3.6 s (+0.02% 🔺) 1.3 s (-25.78% 🔽) 4.8 s
polaris-viz-css 4.72 KB (0%) 95 ms (0%) 201 ms (-46.88% 🔽) 295 ms
polaris-viz-esnext 181.89 KB (+0.02% 🔺) 3.7 s (+0.02% 🔺) 1.2 s (-30.71% 🔽) 4.8 s