github-actions[bot]
commented
1 week ago size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| polaris-viz-core-cjs | 61.64 KB (+0.03% 🔺) | 1.3 s (+0.03% 🔺) | 1.1 s (+31.29% 🔺) | 2.3 s |
| polaris-viz-cjs | 223.6 KB (+0.18% 🔺) | 4.5 s (+0.18% 🔺) | 2.1 s (+9.8% 🔺) | 6.5 s |
| polaris-viz-esm | 180.89 KB (-0.07% 🔽) | 3.7 s (-0.07% 🔽) | 1.6 s (-4.31% 🔽) | 5.2 s |
| polaris-viz-css | 5.55 KB (-0.06% 🔽) | 112 ms (-0.06% 🔽) | 263 ms (-12.72% 🔽) | 374 ms |
| polaris-viz-esnext | 187.64 KB (-0.08% 🔽) | 3.8 s (-0.08% 🔽) | 1.7 s (+24.49% 🔺) | 5.5 s |
envex
carysmills
What does this implement/fix?
In order to allow charts to position the tooltip differently, we passed
getPositionandgetAlteredPositionfunctions toTooltipWrapper.Following this logic was confusing, so now we're going to pass the
chartTypetoTooltipWrapperand handle all the different chart logic beside the rendering of the tooltip.This should allow us to further improve the tooltip logic in smaller PRs.
Storybook link
There should be no visual changes to the charts and tooltips should behave the way the previously behaved.
https://6062ad4a2d14cd0021539c1b-iplfayxntw.chromatic.com/
Before merging
[x] Check your changes on a variety of browsers and devices.
[x] Update the Changelog's Unreleased section with your changes.
[ ] Update relevant documentation, tests, and Storybook.
[ ] Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package