Shopify / polaris-viz

A collection of React and React native components that compose Shopify's data visualization system
https://polaris-viz.shopify.dev
Other
335 stars 25 forks source link

fix, Tooltip should be render inside `polaris_viz_tooltip_root` #1761

Closed Passanelli closed 1 week ago

Passanelli commented 1 week ago

What does this implement/fix?

We need to make use of the polaris_viz_tooltip_root element through createPortal in order to make tooltips always visible

Does this close any currently open issues?

Storybook link

storybook URL

Before merging

github-actions[bot] commented 1 week ago

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.63 KB (0%) 1.3 s (0%) 981 ms (+10.42% 🔺) 2.3 s
polaris-viz-cjs 223.22 KB (+0.04% 🔺) 4.5 s (+0.04% 🔺) 1.7 s (-7.08% 🔽) 6.2 s
polaris-viz-esm 181.01 KB (+0.05% 🔺) 3.7 s (+0.05% 🔺) 1.6 s (-11.86% 🔽) 5.2 s
polaris-viz-css 5.56 KB (+0.11% 🔺) 112 ms (+0.11% 🔺) 254 ms (-22.86% 🔽) 365 ms
polaris-viz-esnext 187.78 KB (+0.05% 🔺) 3.8 s (+0.05% 🔺) 1.4 s (-16.33% 🔽) 5.1 s