github-actions[bot]
commented
1 week ago size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| polaris-viz-core-cjs | 61.65 KB (+0.04% 🔺) | 1.3 s (+0.04% 🔺) | 1.2 s (+24.04% 🔺) | 2.4 s |
| polaris-viz-cjs | 222.7 KB (-0.24% 🔽) | 4.5 s (-0.24% 🔽) | 2.1 s (+3% 🔺) | 6.6 s |
| polaris-viz-esm | 180.54 KB (-0.26% 🔽) | 3.7 s (-0.26% 🔽) | 1.7 s (+12.4% 🔺) | 5.3 s |
| polaris-viz-css | 5.55 KB (-0.15% 🔽) | 111 ms (-0.15% 🔽) | 344 ms (+9.69% 🔺) | 455 ms |
| polaris-viz-esnext | 187.26 KB (-0.28% 🔽) | 3.8 s (-0.28% 🔽) | 1.3 s (-14.46% 🔽) | 5.1 s |
philschoefer
What does this implement/fix?
As an improvement to https://github.com/Shopify/polaris-viz/pull/1757 we're moving
containerBoundsto theChartContextso we no longer have to prop drill it.We're also removing
containerDimensionswhich was a subset ofcontainerBounds. We will usecontainerBoundsfrom now on.Storybook link
Before merging
[ ] Check your changes on a variety of browsers and devices.
[ ] Update the Changelog's Unreleased section with your changes.
[ ] Update relevant documentation, tests, and Storybook.
[ ] Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package