search

Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.79k stars 1.17k forks source link

Add subtitle to the PageSkeleton component #11494

Closed ryanrphillips closed 1 month ago

ryanrphillips commented 8 months ago

Feature request summary

The Page component has title and subtitle props and we have quite a few cases where these are static values. However, the PageSkeleton component only supports the title prop, causing the page to jump when the subtitle loads in as part of the Page component.

Rationale

The primary reason for adding this is to achieve better parity with the Page component and prevent the page from jumping.

🌟 Feature requests that are not yet planned will be closed. We then use the issue’s :+1: upvotes to track and set priorities. See the contribution guidelines for more information.

alex-page commented 8 months ago

@ryanrphillips that sounds logical to me. If you wanted to contribute this please do.

github-actions[bot] commented 2 months ago

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.