Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.78k stars 1.17k forks source link

[polaris.shopify.com] Feedback (on /components/tables/index-table?example=index-table-with-empty-state) #11755

Open WebKenth opened 6 months ago

WebKenth commented 6 months ago

Copying the HTML from this results in bad HTML

<div class="Polaris-LegacyCard">
  <div class="Polaris-IndexTable">
    <div class="Polaris-IndexTable__IndexTableWrapper">
      <div class="Polaris-IndexTable__EmptySearchResultWrapper">
        <div class="Polaris-LegacyStack Polaris-LegacyStack--vertical Polaris-LegacyStack--alignmentCenter">
          <div class="Polaris-LegacyStack__Item">
            <img alt="Empty search results" src="data:image/svg+xml,%3csvg width='60' height='60' xmlns='http://www.w3.org/2000/svg'%3e%3cpath fill-rule='evenodd' d='M41.87 24a17.87 17.87 0 11-35.74 0 17.87 17.87 0 0135.74 0zm-3.15 18.96a24 24 0 114.24-4.24L59.04 54.8a3 3 0 11-4.24 4.24L38.72 42.96z' fill='%238C9196'/%3e%3c/svg%3e" draggable="false">
            </div>
            <div class="Polaris-LegacyStack__Item">
              <p class="Polaris-Text--root Polaris-Text--headingLg">No customers yet</p>
            </div>
            <div class="Polaris-LegacyStack__Item">
              <span class="Polaris-Text--root Polaris-Text--subdued">
                <p>Try changing the filters or search term</p>
              </span>
            </div>
          </div>
        </div>
      </div>
    </div>
  </div>

Missing one </div> at the end

github-actions[bot] commented 2 weeks ago

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.