Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.76k stars 1.17k forks source link

App bridge Modal popup > message not displayed on center of the modal screen by default. Why? #12147

Open darakhsa opened 3 months ago

darakhsa commented 3 months ago

Summary

Hello,

Please see I have used ui-modal > latest app bridge SDK & how 'message' looks by default in modal popup.

FYI: Our app used bootstrap css & app bridge and earlier it's working perfectly with app bridge v3.

Screenshot > css_modal_app_brdg_iss

Even I have tried to set padding to display message in center of content area but still it fails.

Please guide me how to fix it ASAP.

NOTE: We can't change bootstrap css framework inclusion to our app and earlier it is working perfectly in app bridge v3 even with bootstrap css.

This is simple confirmation modal pop-up, so we don't need to provide "src" type of modal popup to fix this css issue.

Expected behavior

It should work as it was working flawlessly with app bridge v3 by default.

Actual behavior

Wrap animated gifs/videos in a details tag:

Summary of your gif(s) Description of what the gif shows

Steps to reproduce

[Link to sandbox]()

Are you using React components?

None

Polaris version number

No response

Browser

No response

Device

No response

kisuka commented 1 month ago

Do a <Box> with padding.