Popover does not refocus onto activator after close

[kellydanma]

Summary

According to our docs:

When the popover is closed, focus returns to the element that launched it

I tried testing this out and it is not the case when the popover closes... unless I'm misinterpreting the docs somewhere? I'm not sure if this is working as intended or is a bug, to be honest. Happy to log an issue if it's undesired behaviour, and work on it too 🙏

Expected behavior

I was expecting focus to return to the button "More actions" once the popover closed.

Actual behavior

Instead, focus is lost and restarts at the beginning of the page.

Steps to reproduce

🔗 See sandbox

Are you using React components?

Yes

Polaris version number

latest

Browser

Chrome

Device

MacOS

[kellydanma]

From Slack discussion with @AndrewMusgrave:

Ohhhhhh! I took a look at the example, Polaris will only manage focus when they close the popover. If we close it ourselves (e.g. action list action), that'll be on us to manage focus

https://github.com/Shopify/polaris/blob/d87e976c36230b4e9256bc23fd542cffd1b62ccf/polaris-react/src/components/Popover/Popover.tsx#L153