alex-page commented 3 years ago

Issue summary

[ ] Reduce the duplicated yarn yarn storybook:build yarn build scripts
[x] Fix shrink ray reporting
[x] Get chromatic links in PR's
[x] Get Percy to visual regression test base branches correctly e.g. (version-6.0.0 and a PR pointing towards should compare each other)

BPScott commented 3 years ago

Contrasting the checks that appear in #3739 (the original GH actions PR) vs #3752:

3752 caused the following breakages:

The "Shrink-Ray: Net Diff" report is no longer generated correctly. It is stuck on "pending". Probably because using pull_request causes the action to checkout and use a merge commit instead of the actual one.
The "Storybook Publish" check is no longer present. For the same reason. The chromatic docs suggest that it should be ran on a push event not a pull_request per https://www.chromatic.com/docs/cli#usage-in-a-github-action.

For the Shrink-ray stuff we'll need to update https://github.com/Shopify/polaris-react/blob/master/scripts/build-shrink-ray.js to pluck out commit sha's and base shas / branch names from environment in the same way as the Chromatic action: https://github.com/chromaui/action/blob/release/v1/src/main.ts#L24-L57

BPScott commented 3 years ago

martenbjork commented 2 years ago

@alex-page Is this issue still relevant?

alex-page commented 2 years ago

Nope thanks