Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.78k stars 1.17k forks source link

[Typography] [Migration] Update legacy type styles in the admin #7752

Closed sarahill closed 1 year ago

sarahill commented 1 year ago

Google doc with details

sarahill commented 1 year ago

Update these section headings to use headinSm instead of headingXs

Order details

Screenshot 2022-11-17 at 10 16 28 AM

Draft order details

image
sarahill commented 1 year ago

Update these section headings to use headinSm instead of headingXs

Customer details

image
sarahill commented 1 year ago

Update these section headings to use headinSm instead of headingXs

Product details

Screenshot 2022-11-17 at 10 24 19 AM
sarahill commented 1 year ago

Pick a plan

image image
sarahill commented 1 year ago

Settings > Users and permissions > Transfer ownership

2022-11-17 12 03 46

sarahill commented 1 year ago

Settings > Shipping and delivery

Card section headings "General shipping rates" "Custom shipping rates" "Manage delivery by location" "Manage pickup by location"

image image
sarahill commented 1 year ago

Settings > Markets > Domains and languages

Table headers using legacy subheading styles

image

Section headings: Primary domain, domain or sudomain, subfolders

2022-11-17 12 19 58

sarahill commented 1 year ago

Settings > Apps and sales channels

Card section headings

2022-11-17 12 21 46

laurkim commented 1 year ago

Update these section headings to use headinSm instead of headingXs

Order details

Draft order details

@sarahill I'm going to go these comment by comment and respond with screenshots of the fixes. Going to exclude the images you provided to minimize confusion of screenshots.

Order details customer card update:

order-details-customer-card

Draft order details customer card update:

draft-order-details-customer-card
laurkim commented 1 year ago

Update these section headings to use headinSm instead of headingXs

Customer details

Customer detail page customer card

customer-details-customer-card
laurkim commented 1 year ago

Update these section headings to use headinSm instead of headingXs

Product details

Product details page product status card

product-details-card-product-status
laurkim commented 1 year ago

Settings > Shipping and delivery

Card section headings "General shipping rates" "Custom shipping rates" "Manage delivery by location" "Manage pickup by location"

Settings page shipping card

settings-shipping-shipping-card

Settings page local delivery card

settings-shipping-local-delivery-card

Settings page local pickup card

settings-shipping-local-pickup-card
laurkim commented 1 year ago

Settings > Users and permissions > Transfer ownership

settings-usersnpermissions-transfer-store-ownership

The translation file has the NEW STORE OWNER copy as capitalized so I've left it as so, just changed the variant.

sarahill commented 1 year ago

@laurkim All the above look good. I was going through all the pages and checking one more time and noticed one more odd thing.

The numbers on the customer details page are really small for some reason. See gif for comparison. It actually looks like it's using the right variant too 🤔

image

2022-11-18 09 02 22

image
sarahill commented 1 year ago

@laurkim One more and this should be it. I went over pages a few times.

The section heading on the skeleton loading state for the customer details page. Hard to inspect it but it looks like it's using the headingXs instead of headingSm. Other pages with this loading state look correct.

Screenshot 2022-11-18 at 9 08 22 AM
laurkim commented 1 year ago

Settings > Markets > Domains and languages

Table headers using legacy subheading styles

Section headings: Primary domain, domain or sudomain, subfolders

@sarahill re: table headers, those aren't using any typography components, just plain old <th> elements. We should probably flag that to the team that owns it.

Settings -> Markets -> Domains and languages settings-domains-and-languages

laurkim commented 1 year ago

Settings > Apps and sales channels

Card section headings

Settings -> Apps -> Privacy details card

settings-apps-privacy-details

Settings -> Apps -> Permission details card settings-apps-permission-details

sarahill commented 1 year ago

Order details

Link Additional details on notes Image

sarahill commented 1 year ago

Settings > Users and permissions > Add staff

Headings about checkbox lists:

image
laurkim commented 1 year ago

Pick a plan

Settings -> Plan -> Pick a plan payments

laurkim commented 1 year ago

@laurkim All the above look good. I was going through all the pages and checking one more time and noticed one more odd thing.

The numbers on the customer details page are really small for some reason. See gif for comparison. It actually looks like it's using the right variant too 🤔

@sarahill I think it's because of the way the Text components were nested, so the inner Text component that was bodyMd that was originally migrated from TextStyle was overriding the <Text variant="headingXl" as="h3"> styling. Just fixed 👍

customer-detail
laurkim commented 1 year ago

@laurkim One more and this should be it. I went over pages a few times.

The section heading on the skeleton loading state for the customer details page. Hard to inspect it but it looks like it's using the headingXs instead of headingSm. Other pages with this loading state look correct.

Customer detail skeleton card customer-details

laurkim commented 1 year ago

Order details

I wasn't able to take a screenshot of this section, but I've updated this to be headingSm

laurkim commented 1 year ago

Settings > Users and permissions > Add staff

Headings about checkbox lists:

  • General
  • Admission
  • Online store
  • Finance
  • Apps and channels

User permissions:

user-permissions

Apps and channels:

apps-and-channels
sarahill commented 1 year ago

Everything looks good! @laurkim thank you 👏