Closed sarahill closed 1 year ago
Update these section headings to use headinSm
instead of headingXs
Update these section headings to use headinSm
instead of headingXs
Update these section headings to use headinSm
instead of headingXs
Card section headings "General shipping rates" "Custom shipping rates" "Manage delivery by location" "Manage pickup by location"
Table headers using legacy subheading styles
Section headings: Primary domain, domain or sudomain, subfolders
Card section headings
Update these section headings to use
headinSm
instead ofheadingXs
Order details
Draft order details
@sarahill I'm going to go these comment by comment and respond with screenshots of the fixes. Going to exclude the images you provided to minimize confusion of screenshots.
Order details customer card update:
Draft order details customer card update:
Update these section headings to use
headinSm
instead ofheadingXs
Customer details
Customer detail page customer card
Update these section headings to use
headinSm
instead ofheadingXs
Product details
Product details page product status card
Settings > Shipping and delivery
Card section headings "General shipping rates" "Custom shipping rates" "Manage delivery by location" "Manage pickup by location"
Settings page shipping card
Settings page local delivery card
Settings page local pickup card
Settings > Users and permissions > Transfer ownership
The translation file has the NEW STORE OWNER
copy as capitalized so I've left it as so, just changed the variant.
@laurkim All the above look good. I was going through all the pages and checking one more time and noticed one more odd thing.
The numbers on the customer details page are really small for some reason. See gif for comparison. It actually looks like it's using the right variant too 🤔
@laurkim One more and this should be it. I went over pages a few times.
The section heading on the skeleton loading state for the customer details page. Hard to inspect it but it looks like it's using the headingXs
instead of headingSm
. Other pages with this loading state look correct.
Settings > Markets > Domains and languages
Table headers using legacy subheading styles
Section headings: Primary domain, domain or sudomain, subfolders
@sarahill re: table headers, those aren't using any typography components, just plain old <th>
elements. We should probably flag that to the team that owns it.
Settings -> Markets -> Domains and languages
Settings > Apps and sales channels
Card section headings
Settings -> Apps -> Privacy details card
Settings -> Apps -> Permission details card
Headings about checkbox lists:
Pick a plan
Settings -> Plan -> Pick a plan
@laurkim All the above look good. I was going through all the pages and checking one more time and noticed one more odd thing.
The numbers on the customer details page are really small for some reason. See gif for comparison. It actually looks like it's using the right variant too 🤔
@sarahill I think it's because of the way the Text components were nested, so the inner Text component that was bodyMd
that was originally migrated from TextStyle
was overriding the <Text variant="headingXl" as="h3">
styling. Just fixed 👍
@laurkim One more and this should be it. I went over pages a few times.
The section heading on the skeleton loading state for the customer details page. Hard to inspect it but it looks like it's using the
headingXs
instead ofheadingSm
. Other pages with this loading state look correct.
Customer detail skeleton card
Order details
I wasn't able to take a screenshot of this section, but I've updated this to be headingSm
Settings > Users and permissions > Add staff
Headings about checkbox lists:
- General
- Admission
- Online store
- Finance
- Apps and channels
User permissions:
Apps and channels:
Everything looks good! @laurkim thank you 👏
Google doc with details