Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.79k stars 1.17k forks source link

[Icon]: Update icon package_major #9163

Closed ksvihar closed 10 months ago

ksvihar commented 1 year ago

Why are you proposing this update?

Currently, we have 3 icons related to packages. package_major, soft-pack_major and envelope_major. These 3 icons show up together in different shipping flows and surface areas (package settings and label purchase flows primarily). They also show up along with Shipping carrier logos which are usually solid logo marks.

Today, only package_major icon is a solid icon today and the other two icons, soft-pack_major and envelope_major are line icons. This makes them inconsistent and it looks like they don't belong to the same icon set. Also, the corner radii on these icons is inconsistent, mostly 1.5px around the edges. We typically use 2px.

Hence, the proposal to update all 3 icons (issues created for each icon separately) to make them more consistent and to ensure all of them follow pixel grid and other icon guidelines.

image

Icon name

package_major

What type of icon set?

Major (20x20)

Icon SVG code

<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M1.00042 6L1 16.9999C0.999958 18.1045 1.8954 19 3 19H17.0004C18.105 19 19.0004 18.1046 19.0004 17V6H1.00042ZM4.00042 12H10.0004V16H4.00042V12Z" fill="#616A75"/>
<path d="M9.00043 4H1.00043L2.40669 1.8906C2.77763 1.3342 3.40209 1 4.07079 1H9.00043V4Z" fill="#616A75"/>
<path d="M11.0004 4H19.0004L17.5942 1.8906C17.2232 1.3342 16.5988 1 15.9301 1H11.0004V4Z" fill="#616A75"/>
</svg>

Are there any other important details?

This icon along with the other two icons are reviewed by @ouellettejordan.

image

github-actions[bot] commented 11 months ago

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.