search

Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.79k stars 1.17k forks source link

[Icon]: Update icon soft-pack_major #9164

Closed ksvihar closed 10 months ago

ksvihar commented 1 year ago

Why are you proposing this update?

Currently, we have 3 icons related to packages. package_major, soft-pack_major and envelope_major. These 3 icons show up together in different shipping flows and surface areas (package settings and label purchase flows primarily). They also show up along with Shipping carrier logos which are usually solid logo marks.

Today, only package_major icon is a solid icon today and the other two icons, soft-pack_major and envelope_major are line icons. This makes them inconsistent and it looks like they don't belong to the same icon set. Also, the corner radii on these icons is inconsistent, mostly 1.5px around the edges. We typically use 2px.

Hence, the proposal to update all 3 icons (issues created for each icon separately) to make them more consistent and to ensure all of them follow pixel grid and other icon guidelines.

image

Icon name

soft-pack_major

What type of icon set?

Major (20x20)

Icon SVG code

<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M2 2C2 0.895431 2.89543 0 4 0H16C17.1046 0 18 0.895431 18 2V3H16V5H18V18C18 19.1046 17.1046 20 16 20H4C2.89543 20 2 19.1046 2 18V5H4V3H2V2ZM5 13H11V17H5V13ZM6 3H9V5H6V3ZM14 3H11V5H14V3Z" fill="#616A75"/>
</svg>

Are there any other important details?

This icon along with the other two icons are reviewed by @ouellettejordan.

image

github-actions[bot] commented 11 months ago

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.