Shopify / polaris

Shopify’s design system to help us work together to build a great experience for all of our merchants.
https://polaris.shopify.com
Other
5.78k stars 1.17k forks source link

Space is reserved for actions, even when the empty state is shown #9592

Closed jas7457 closed 2 months ago

jas7457 commented 1 year ago

Issue summary

If you select some items, and then do something that shows the empty state (such as a search), there is still a lot of padding reserved for the actions, even though none are shown.

Expected behavior

There is no padding

Actual behavior

There is padding

image

Here's a video recorded by a coworker to show the issue.

Steps to reproduce the problem

  1. Visit my codesandbox
  2. Select 1 or more items
  3. Type into the filter text field to show 0 results
  4. Notice there is a bunch of extra padding

Reduced test case

Codesandbox

Specifications

Or run npx envinfo --system --binaries --browsers --npmPackages react,react-dom,@shopify/polaris to provide specifications on your environment including version numbers, browser, device, and operating system.

Paste the results here:

github-actions[bot] commented 9 months ago

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

jas7457 commented 9 months ago

It looks like this is still an issue on the standbox, it'd be great to get fixed.

github-actions[bot] commented 3 months ago

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.