Additional linespaces added with every format

[andyxmas]

Describe the bug In some liquid snippets, examples below, the when running prettier, have extra line spaces added every time.

Unformatted source I've done my best to make this as minimal as possible.

<script>  
  window.someKey = {
    {% if customer %}
      customer: {
        name: '{{ customer.first_name }}'
      },
    {% endif %}
    somethingElse: {
      anotherKey: `someString`
    }
  };
</script>

Expected output No change, or potentially some formatting, but not additional linespaces.

Actual output

<script>

  window.someKey = {
    {% if customer %}
      customer: {
        name: '{{ customer.first_name }}'
      },
    {% endif %}
    somethingElse: {
      anotherKey: `someString`
    }
  };

</script>

Debugging information

• OSX
• Version 1.0.6

Additional context

• This happens in both the command line (version 1.0.6) and the vscode plugin (latest?)
• In my testing, I can see that if I remove the `` backticks, the issue does not present. Also, if I remove the{% if ... %}` statement.

[charlespwd]

Thanks for reporting :)

[Catalin-G]

Any news about this?

[Wilhansen]

took a stab in fixing the bug on a surface level ☝️

the bug triggers if the script tag contents contain both liquid tags and the backtick for template literals, in addition to the newline, the backtick also disables prettifying (or at least, indentation) of the block (but that's for another issue).

[JasonHassold]

I'm also having this issue, every time a script tag contains backticks

[charlespwd]

I believe this was fixed in the latest version by https://github.com/Shopify/theme-tools/pull/163