Empty html attribute value throws error with Node v14

Shopify / prettier-plugin-liquid

Prettier Liquid/HTML plugin

https://npm.im/@shopify/prettier-plugin-liquid

MIT License

93 stars 15 forks source link

Empty html attribute value throws error with Node v14 #204

Closed mattvague closed 1 year ago

mattvague commented 1 year ago

Describe the bug When using this plugin with Node v14, an html attribute with an empty value e.g. <div class=""> will throw an error since Array.prototype.at is used here in the parser but is not supported until (I believe) Node v.16.6.0.

Not sure what the minimum node version you're looking to support is, but I'm happy to fix it and submit a PR if this is deemed worth it

Debugging information

OS: Mac
Version 1.2.2

charlespwd commented 1 year ago

Hi Matt. Node v14 is end of life and we will not support it. I encourage you to update to at least 18, 16 is going end of life in a couple months.

https://nodejs.dev/en/about/releases/