A bug when using >= or <= in a tag

Shopify / prettier-plugin-liquid

Prettier Liquid/HTML plugin

https://npm.im/@shopify/prettier-plugin-liquid

MIT License

93 stars 15 forks source link

Closed its-anas closed 2 years ago

its-anas commented 2 years ago

Describe the bug It adds a space before the end of a tag %} each time it format a tag that uses >= or <= operators.

To reproduce the issue

Create a .liquid file
Add a tag with <= or >= like this: {% if variable >= 1 %} {% endif %}
Format the file. ( Repeat the formatting several times to notice the space issue )

charlespwd commented 2 years ago

Which version of the plugin are you using? Which OS? What settings? (The bug report form would have asked for those)

I feel like 0.3.1 has the fix for your issue but can't tell for sure.

charlespwd commented 2 years ago

Was indeed a bug, will be fixed in next release.

its-anas commented 1 year ago

Sorry I didn't saw your message earlier. I apologize for not including the OS, it was both on Windows and iOS. Thanks for fixing it though!

charlespwd commented 1 year ago

FYI, shipped in v0.4.0 🙏