search

Shopify / product-reviews-sample-app

A sample Shopify application that creates and stores product reviews for a store, written in Node.js
MIT License
351 stars 158 forks source link

Add mention of online store 2.0 to "Extending the app with a Theme Extension" #60

Closed Luke-Kav closed 2 years ago

Luke-Kav commented 2 years ago

Hey folks 👋

I was testing out the The Extending the app with a Theme App Extension guide today and came across a potential gotcha for folks following along.

I previously had installed a non Online Store 2.0 Theme in my store, and for a wee while I was wondering why I couldn't see the Sample App showing in the theme customiser when I was going through the guide.

Turns out it seems it was because I didn't have an published Online Store 2.0 theme on my store 😆

Just adding this PR for the note to theme-app-extension.md so others don't fall into the same trap as they are following along with the guide.

Should look like so -

alt

Maybe it could be included in the FAQ, but I encountered this issue when going through Step 6...anyway, just a thought :)

meganmajewski commented 2 years ago

@Luke-Kav Good catch thanks for adding!

stevemar commented 2 years ago

Thanks for the PR @Luke-Kav and for reviewing @meganmajewski !