search

Shopify / protoboeuf

Experimenting with a protobuf implementation
MIT License
24 stars 2 forks source link

Try to add sigstore proto files to rakefile #81

Closed maximecb closed 3 months ago

maximecb commented 3 months ago

@tenderworks I've added the sigstore proto files to the repo, but I'm not sure how to adjust the rakefile

Here I've added them to the proto_files list, but I'm getting the following error when running rake test. Advice welcome:

% rake test
rake aborted!
Don't know how to build task '/Users/maximecb/src/github.com/Shopify/protoboeuf/lib/proto/test/fixtures/envelope_pb.rb' (See the list of available tasks with `rake --tasks`)
Did you mean?  /Users/maximecb/src/github.com/Shopify/protoboeuf/lib/proto/test/fixtures/test_pb.rb

Tasks: TOP => test => gen_proto
(See full trace by running task with --trace)
tenderworks commented 3 months ago

What do we want to test exactly? The Rakefile is only used for generating code with Google's implementation of Protobuf. If we just want to test that our .proto parser can parse the sigstore proto files, then we don't need to add anything to the Rakefile.

I'd only expect us to be integrating these .proto file in to the Rakefile if we wanted to compare Google's implementation to ours (which I don't think we need to do since we've already tested all types).