Shopify / quilt

[⚠️ Deprecated] A loosely related set of packages for JavaScript/TypeScript projects at Shopify
MIT License
1.7k stars 220 forks source link

Update koa-shopify-webhooks README #1091

Open dimensioncalculator opened 5 years ago

dimensioncalculator commented 5 years ago

Overview

Minor issue on readme - https://github.com/Shopify/quilt/tree/master/packages/koa-shopify-webhooks/README

You need to make a correction to -

Section - koa-router and multiple webhooks

router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/products/create', webhook, () => { /* handle orders create */ });

Should read order for second post function -

router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/**orders**/create', webhook, () => { /* handle orders create */ }); ...

Consuming repo

What repo were you working in when this issue occurred?

...

Labels

Area

Scope


Checklist

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.