Open dimensioncalculator opened 5 years ago
Minor issue on readme - https://github.com/Shopify/quilt/tree/master/packages/koa-shopify-webhooks/README
You need to make a correction to -
Section - koa-router and multiple webhooks
router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/products/create', webhook, () => { /* handle orders create */ });
Should read order for second post function -
router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/**orders**/create', webhook, () => { /* handle orders create */ }); ...
router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/**orders**/create', webhook, () => { /* handle orders create */ });
What repo were you working in when this issue occurred?
...
Type: Bug
Area: <area>
Is this issue related to a specific package?
Package: <package_name>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
Overview
Minor issue on readme - https://github.com/Shopify/quilt/tree/master/packages/koa-shopify-webhooks/README
You need to make a correction to -
Section - koa-router and multiple webhooks
router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/products/create', webhook, () => { /* handle orders create */ });
Should read order for second post function -
router.post('/webhooks/products/create', webhook, () => { /* handle products create */ }); router.post('/webhooks/**orders**/create', webhook, () => { /* handle orders create */ });
...Consuming repo
...
Labels
Type: Bug
label to this issue.Area
Area: <area>
labels to this issueScope
Is this issue related to a specific package?
Package: <package_name>
label.Checklist