Shopify / quilt

[⚠️ Deprecated] A loosely related set of packages for JavaScript/TypeScript projects at Shopify
MIT License
1.7k stars 220 forks source link

Easier troubleshooting for SSR failures #1737

Open GoodForOneFare opened 3 years ago

GoodForOneFare commented 3 years ago

Overview

It would be nice if @shopify/async reported errors caught during SSR component lookups. @shopify/async/resolver currently discards error output: https://github.com/Shopify/quilt/blob/997e69e6ff16224a0dc69da88576dbbaefc24cdd/packages/async/src/resolver.ts#L86-L98

Motivation

We recently adopted @babel/transform-runtime in a large app, which (due to the way the transform exposes default exports) failed on some server-side circular imports. The errors silently broke SSR, but were obvious once I added output to async's // Just ignore failures block.

cc @vsumner because this is your current headache 😸 cc @lemonmade since this likely affects the lemony equivalents of async.

lemonmade commented 3 years ago