We recently adopted @babel/transform-runtime in a large app, which (due to the way the transform exposes default exports) failed on some server-side circular imports. The errors silently broke SSR, but were obvious once I added output to async's // Just ignore failures block.
cc @vsumner because this is your current headache 😸 cc @lemonmade since this likely affects the lemony equivalents of async.
Overview
It would be nice if
@shopify/async
reported errors caught during SSR component lookups.@shopify/async/resolver
currently discards error output: https://github.com/Shopify/quilt/blob/997e69e6ff16224a0dc69da88576dbbaefc24cdd/packages/async/src/resolver.ts#L86-L98Motivation
We recently adopted
@babel/transform-runtime
in a large app, which (due to the way the transform exposesdefault
exports) failed on some server-side circular imports. The errors silently broke SSR, but were obvious once I added output to async's// Just ignore failures
block.cc @vsumner because this is your current headache 😸 cc @lemonmade since this likely affects the lemony equivalents of
async
.