search

Shopify / quilt

[⚠️ Deprecated] A loosely related set of packages for JavaScript/TypeScript projects at Shopify
MIT License
1.7k stars 222 forks source link

Semantic versioning and major version bump for breaking changes? #2802

Open egenerat opened 4 months ago

egenerat commented 4 months ago

Overview

Question regarding quilt/packages/react-hooks/CHANGELOG.md at a098a217057cbab34d16363bbac69b5835dc7b65 · Shopify/quilt

3.0 was a major version because of

Breaking Change
Drop support for node 12 and Safari 10, 11 and 12. Remove wildcard export in exports field. [https://github.com/Shopify/quilt/pull/2277]

Should 3.2 have been a major version as well?

Minor Changes
https://github.com/Shopify/quilt/pull/2785 [97f8f6cf5](https://github.com/Shopify/quilt/commit/97f8f6cf5f0f5c8adc03ff6d907fb16d878fbece) Thanks [@vsumner](https://github.com/vsumner)! - Drop support for node 14 and 16. Support node LTS and up.

https://github.com/Shopify/quilt/pull/2787 [f50049004](https://github.com/Shopify/quilt/commit/f500490042d922b66a6781c3450f876a83a120cb) Thanks [@vsumner](https://github.com/vsumner)! - Drop support for React 17