The @shopify/network package is currently listed as a devDependency for the @shopify/react-performance package. I think this is incorrect as the package is referenced from from performanceReport file.
I have moved the package from devDependency to dependency to resolve.
That said, if we look at the usage of the package in the file, it's simply to reference two constants, so I wonder if we're more comfortable/pragmatic in simply inlining these definitions?
Description
The
@shopify/network
package is currently listed as adevDependency
for the@shopify/react-performance
package. I think this is incorrect as the package is referenced from from performanceReport file.I have moved the package from
devDependency
todependency
to resolve.That said, if we look at the usage of the package in the file, it's simply to reference two constants, so I wonder if we're more comfortable/pragmatic in simply inlining these definitions?
Header.ContentType
https://github.com/Shopify/quilt/blob/75ea9fe52b65f001b238d3d21e76c3181badfe6c/packages/react-performance/src/performance-report.ts#L46
Method.Post
https://github.com/Shopify/quilt/blob/75ea9fe52b65f001b238d3d21e76c3181badfe6c/packages/react-performance/src/performance-report.ts#L44