Shopify / quilt

[⚠️ Deprecated] A loosely related set of packages for JavaScript/TypeScript projects at Shopify
MIT License
1.7k stars 221 forks source link

Move @shopify/network to dependencies in react-performance #2819

Closed brendo closed 2 months ago

brendo commented 3 months ago

Description

The @shopify/network package is currently listed as a devDependency for the @shopify/react-performance package. I think this is incorrect as the package is referenced from from performanceReport file.

I have moved the package from devDependency to dependency to resolve.

That said, if we look at the usage of the package in the file, it's simply to reference two constants, so I wonder if we're more comfortable/pragmatic in simply inlining these definitions?

https://github.com/Shopify/quilt/blob/75ea9fe52b65f001b238d3d21e76c3181badfe6c/packages/react-performance/src/performance-report.ts#L46

https://github.com/Shopify/quilt/blob/75ea9fe52b65f001b238d3d21e76c3181badfe6c/packages/react-performance/src/performance-report.ts#L44

jesstelford commented 2 months ago

+1 to inlining - the fewer dependencies the better 👍