search

Shopify / quilt

[⚠️ Deprecated] A loosely related set of packages for JavaScript/TypeScript projects at Shopify
MIT License
1.7k stars 222 forks source link

Fix typescript error in i18n #2821

Closed alex-page closed 3 months ago

alex-page commented 3 months ago

Updated NumberFormatOptionsStyleRegistry to align with latest version of typescript.

alex-page commented 3 months ago

/snapit

github-actions[bot] commented 3 months ago

🫰✨ Thanks @alex-page! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

"@shopify/react-i18n": "0.0.0-snapshot-20240828004508",
"@shopify/react-i18n-universal-provider": "0.0.0-snapshot-20240828004508"
alex-page commented 3 months ago

Tophatted in /web in https://github.com/Shopify/web/pull/138778

There were some issues but they can be fixed forward in /web. Nothing critical from what I could see quickly.