Shopify / rbi-central

MIT License
55 stars 36 forks source link

Updates ActionMailer.mail block param's type to include its param type #233

Closed joseph-carino closed 6 months ago

joseph-carino commented 6 months ago

Description

Upgrading our app to rails 7.1.2 caused new sorbet issues with our usage of ActionMailer.mail: as the block param's sorbet type does not include the type of the param, sorbet is incorrectly typing the param NilClass.

Looks like the type of this param is ActionMailer::Collector so I've updated the annotation type accordingly.

Type of Change

Changes