Integrate with Sorbet - Githubissues

Shopify / rbs_parser

Ruby RBS parsing and translation to Sorbet RBI

MIT License

27 stars 4 forks source link

Open Morriar opened 4 years ago

Morriar commented 4 years ago

Like sorbet --rbs to run this?

Morriar commented 4 years ago

I opened a PR to integrate rbs_parser directly into Sorbet: https://github.com/sorbet/sorbet/pull/2828

Morriar commented 4 years ago

Update: I met with Jake last Thursday to talk about the PR.

Since he didn't do the review on the PR, I'll post the two main comments he did:

I need to change all the pointers to smart pointers (currently working on that)
The dependency to rbs_parser can be modelled as a bazel dependency instead of using a ad-hoc script

They also are uncomfortable to have this as an external dependency. I'm not against merging it into Sorbet when we reach a stable version or RBS.