search

Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.64k stars 420 forks source link

Video player fixes #2451

Closed wcandillon closed 1 month ago

wcandillon commented 1 month ago

fixes #2442

wcandillon commented 1 month ago

@mrEuler this is work in progress but this will allow us to have test cases for the video playing logic so we can have it more stable. About the video orientation, I will add the possibility to get the preferred SkMatrix for that video.

mrEuler commented 1 month ago

@wcandillon you are rock! Let's not close the issue itself, so I can post more finding there and have it as the main thread for video issues.

wcandillon commented 1 month ago

I think it would be good to make separate small issues as I am starting to lose track of all the open issues

On Wed 29 May 2024 at 10:27, OleksiiMaksymov @.***> wrote:

@wcandillon https://github.com/wcandillon you are rock! Let's not close the issue itself, so I can post more finding there and have it as the main thread for video issues.

— Reply to this email directly, view it on GitHub https://github.com/Shopify/react-native-skia/pull/2451#issuecomment-2136837710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKXVWQLULAJFPQ7GTDJXDZEWGPNAVCNFSM6AAAAABIONI6ZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZWHAZTONZRGA . You are receiving this because you were mentioned.Message ID: @.***>

wcandillon commented 1 month ago

@mrEuler I have more improvements I want to bring to this feature but in the meantime, here we have a basis to collaborate, we can add examples, test cases, and follow different issues on the topic

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.3.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: