fix(🧵): thread safety in RNSkJsiViewApi.h

Shopify / react-native-skia

High-performance React Native Graphics using Skia

https://shopify.github.io/react-native-skia

MIT License

6.64k stars 420 forks source link

fix(🧵): thread safety in RNSkJsiViewApi.h #2481

Closed wcandillon closed 2 weeks ago

wcandillon commented 2 weeks ago

@hannojg reported an error indicating that a crash can sporadically happen in RNSkJsiViewApi.h. The state of RNSkJsiViewApi is modified from both the UI and JS thread and by reviewing the code we found concurrency cases that could lead to crashes.

Partially solves #2396 (maybe completely)

github-actions[bot] commented 2 weeks ago

:tada: This PR is included in version 1.3.5 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: