search

Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.95k stars 447 forks source link

Segfault on Android - sk_sp<T>::reset #2609

Open matinzd opened 2 months ago

matinzd commented 2 months ago

Description

Link to Sentry stacktrace: https://lendo.sentry.io/share/issue/4a599f0628974be0b209803563b36916/

Segfault - sk_sp<T>::reset

Version

1.2.3

Steps to reproduce

I could not reproduce this but it seems like it's happening on low-end devices.

Snack, code example, screenshot, or link to a repository

Image

matinzd commented 2 months ago

Adding it here just in case upgrading does not solve it.

matinzd commented 2 months ago

@wcandillon Can this be related to https://github.com/Shopify/react-native-skia/pull/2505?

matinzd commented 2 months ago

Documenting just in case someone is getting segfault on Android. Tried adding cancelAnimation on shared values and upgraded to the latest version of RN Skia. Seems the fix is working as of now.

Before: Image

After: Image

wcandillon commented 1 month ago

@matinzd my apologies for only following up on this now. Anything there we should do on our side?

matinzd commented 1 month ago

It's still happening after updating skia again.

Here is the link to sentry report:

https://lendo.sentry.io/share/issue/c2d3c8bf1a30495a8b841002b2778825/