Improve unmount behavior

Shopify / react-native-skia

High-performance React Native Graphics using Skia

https://shopify.github.io/react-native-skia

MIT License

6.98k stars 452 forks source link

Closed wcandillon closed 2 months ago

wcandillon commented 2 months ago

Before:

After:

To achieve this behaviour we needed to do two things:

Remove root deletion when unmounting (the root is deleted in the view destructor)
Don't update the drawing if the update is an unmount command

cc @colinta @beardwin

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.3.12 :tada:

The release is available on:

Your semantic-release bot :package::rocket: