Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.98k stars 452 forks source link

Installation issue after upgrade to 1.4.0 #2664

Closed santitopo closed 1 month ago

santitopo commented 1 month ago

Description

After upgrading to v1.4.0 I'm getting an issue when installing the app in iOS. The errors thrown are:

Multiple commands produce '/Users/user_name/Library/Developer/Xcode/DerivedData/projectName-cqlfmtjboujykabujkqvrublhouw/Build/Products/Debug-Dev-iphonesimulator/react-native-skia/react_native_skia.framework/Headers/GrBackendSemaphore.h'

The same happens with various header files, all prefixed with 'Gr' and sourced both from cpp/skia/include/gpu/ and cpp/skia/include/gpu/ganesh (probably related to changes in copy-skia-module-headers.ts)

Image

Version

1.4.0

React Native 0.73.9

Steps to reproduce

Upgrade and attempt installation in ios

Snack, code example, screenshot, or link to a repository

"react-native": "0.73.9", "@shopify/react-native-skia": "~1.4.0",

wcandillon commented 1 month ago

thanks for reporting this, will fix it asap

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 1.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

fatiherdogan01 commented 1 month ago

Hi, I also have this issue in version 1.4.1. RN: 0.75.3

wcandillon commented 1 month ago

could it be that you need a fresh pod install/build? maybe you have duplicate hears from a previous version? But I will look into it in the meantime.

On Tue, Oct 1, 2024 at 11:21 AM Fatih Erdoğan @.***> wrote:

Hi, I also have this issue in version 1.4.1. RN: 0.75.3

— Reply to this email directly, view it on GitHub or unsubscribe. You are receiving this email because you commented on the thread.

Triage notifications on the go with GitHub Mobile for iOS or Android.

TomCorvus commented 1 month ago

Hi @wcandillon, I have the same problem with the 1.4.1 version. I tried to clean build cache, node_modules folder and re-install all of these but the same error appears:

Multiple commands produce '/Users/user_name/Library/Developer/Xcode/DerivedData/project-dzfoskxqtdujzmffpofvglurexrc/Build/Products/Debug-iphonesimulator/react-native-skia/react_native_skia.framework/Headers/GrBackendSemaphore.h'
sohail-wayland commented 1 month ago

I can also confirm this. Even with v1.4.1, I get the same error despite deleting pods, cleaning cache/build folder etc.

wcandillon commented 1 month ago

my apologies for this. I was confused about the issue, publishing a fix for it now.

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 1.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

justindavies commented 3 weeks ago

Hey @wcandillon I seem to have this is with the 1.5.0 build too:

'include/gpu/ganesh/GrDirectContext.h' file not found