search

Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.98k stars 452 forks source link

Remove deprecated onTouch prop #2669

Closed wcandillon closed 1 month ago

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

abretonc7s commented 1 month ago

What is the way to do without it? How to keep code backward compatible?

enchorb commented 4 weeks ago

+1 to the above

@wcandillon This is a breaking change with no details on how to upgrade. All our graphs broke after upgrading

We originally built our graph functionality following your tutorial https://www.youtube.com/watch?v=xeLdmn3se1I

wcandillon commented 4 weeks ago

My apologies for this. Since we weren't documenting nor using this API in our example since before v1 so we thought this was a safe change. We also had a warning about the upcoming deprecation running for months.

You can migrate to gesture-handler: https://shopify.github.io/react-native-skia/docs/animations/gestures/

What will probably be helpful is to check how we migrated our examples away from onTouch: https://github.com/Shopify/react-native-skia/pull/1867/files#diff-3200f36c36a56adec9488807d243b92f3ea662d8e6cb3a23246b2b915b2c0702

I hope this helps. Hopefully the migration should straightforward.