Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.98k stars 452 forks source link

Android build broken on React Native 0.76 New Architecture #2692

Closed oblador closed 1 month ago

oblador commented 1 month ago

Description

Due to https://github.com/react-native-community/discussions-and-proposals/discussions/816, many of the linked libraries no longer exist so the library won't build.

Version

1.4.2

Steps to reproduce

  1. Create a bare project on RN 0.76 RC.4
  2. Add RN Skia dependency
  3. Enable new architecture
  4. Build android -> fail build

Snack, code example, screenshot, or link to a repository

  CMake Error at CMakeLists.txt:41 (add_library):
    Target "rnskia" links to target "ReactAndroid::react_nativemodule_core" but
    the target was not found.  Perhaps a find_package() call is missing for an
    IMPORTED target, or an ALIAS target is missing?

  CMake Error at CMakeLists.txt:41 (add_library):
    Target "rnskia" links to target "ReactAndroid::reactnativejni" but the
    target was not found.  Perhaps a find_package() call is missing for an
    IMPORTED target, or an ALIAS target is missing?

  CMake Error at CMakeLists.txt:41 (add_library):
    Target "rnskia" links to target "ReactAndroid::runtimeexecutor" but the
    target was not found.  Perhaps a find_package() call is missing for an
    IMPORTED target, or an ALIAS target is missing?

  CMake Error at CMakeLists.txt:41 (add_library):
    Target "rnskia" links to target "ReactAndroid::turbomodulejsijni" but the
    target was not found.  Perhaps a find_package() call is missing for an
    IMPORTED target, or an ALIAS target is missing?
github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 1.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: