Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.97k stars 448 forks source link

Firestore iOS build error #2700

Closed blueromans closed 2 weeks ago

blueromans commented 3 weeks ago

Description

Im getting 'RNSkInfoParameter.h' file not found error when I try to use with Firestore. I tried difficult version combination however I couldn't build. Current version 1.5.0 and react-native-skottie: 2.1.4

Version

1.5.0

Steps to reproduce

Add firestore and react-native-skottie to project

Snack, code example, screenshot, or link to a repository

 "dependencies": {
    "@openspacelabs/react-native-zoomable-view": "^2.1.6",
    "@react-native-community/datetimepicker": "^8.2.0",
    "@react-native-firebase/app": "^21.2.0",
    "@react-native-firebase/firestore": "^21.2.0",
    "@react-native-firebase/messaging": "^21.2.0",
    "@react-native-masked-view/masked-view": "^0.3.0",
    "@react-navigation/bottom-tabs": "^6.6.1",
    "@react-navigation/native": "^6.1.9",
    "@react-navigation/stack": "^6.3.20",
    "@reduxjs/toolkit": "^2.2.8",
    "@sentry/react-native": "^5.33.2",
    "@shopify/flash-list": "^1.7.1",
    "@shopify/react-native-skia": "^1.5.0",
    "@tanstack/react-query": "^5.8.9",
    "date-fns": "^4.1.0",
    "i18next": "^23.7.7",
    "ky": "^1.1.3",
    "react": "^18.3.1",
    "react-hook-form": "^7.53.0",
    "react-i18next": "^13.5.0",
    "react-native": "^0.75.4",
    "react-native-alert-notification": "^0.4.0",
    "react-native-device-info": "^13.1.0",
    "react-native-element-dropdown": "^2.12.2",
    "react-native-gesture-handler": "^2.14.0",
    "react-native-image-picker": "^7.1.2",
    "react-native-keyboard-aware-scroll-view": "^0.9.5",
    "react-native-mmkv": "2.11.0",
    "react-native-modal-datetime-picker": "^18.0.0",
    "react-native-pager-view": "^6.4.1",
    "react-native-reanimated": "3.15.5",
    "react-native-safe-area-context": "^4.7.4",
    "react-native-screens": "^3.27.0",
    "react-native-skottie": "^2.1.4",
    "react-native-svg": "^15.8.0",
    "react-native-vector-icons": "^10.2.0",
    "react-native-video": "^6.7.0",
    "react-native-video-controls": "^2.8.1",
    "react-redux": "^9.1.2",
    "redux": "^5.0.1",
    "redux-persist": "^6.0.0"
  },

Podfile

pod 'FirebaseCore', :modular_headers => true
pod 'GoogleUtilities', :modular_headers => true
pod 'FirebaseCoreExtension', :modular_headers => true
pod 'FirebaseFirestoreInternal', :modular_headers => true
wcandillon commented 2 weeks ago

closing as a duplicated of https://github.com/margelo/react-native-skottie/issues/59 for which I submitted a fix as well

JimTeva commented 1 week ago

For others: the fix is to remove/comment the line 15 of file node_modules/react-native-skottie/cpp/RNSkSkottieView.h: #include "RNSkInfoParameter.h" (For the moment I recommend doing a patch-package until the PR is approved)