Shopify / react-native-skia

High-performance React Native Graphics using Skia
https://shopify.github.io/react-native-skia
MIT License
6.98k stars 452 forks source link

Fix Android threading issue #2749

Closed wcandillon closed 2 days ago

wcandillon commented 2 days ago

Currently every offscreen surfaces share the same root context even though they can be created from different thread. This can easily cause crashes, especially in viewRef.makeImageSnapshot which is using an offscreen surface.

We also suspect that because onscreen surfaces are using the parent context where all the offscreen surfaces are created with, it may also cause some error.

We also took advantage of the issue to make a refactoring of the OpenGL logic.

github-actions[bot] commented 2 days ago

:tada: This PR is included in version 1.5.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: